Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/5005#issuecomment-81877899
@debasish83 Thanks for testing the performance! Let's try to make PR
minimal. For example, we can make a separate PR for replacing MLlib's NNLS
implementation by breeze's. I like this change because then we only need to
maintain it in breeze. But we need to make sure the performance/accuracy are
about the same. Do you see a clear way of splitting this PR?
If breeze uses iterator to access elements, it will be much slower than
array lookups.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
