tianshizz commented on a change in pull request #28445: URL: https://github.com/apache/spark/pull/28445#discussion_r419446402
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala ########## @@ -81,6 +81,12 @@ object DateTimeUtils { } } + private val threadLocalUtcGregorianCalendar = new ThreadLocal[GregorianCalendar] { + override def initialValue(): GregorianCalendar = { + new GregorianCalendar(TimeZoneUTC) Review comment: Based on the implementation (https://github.com/JetBrains/jdk8u_jdk/blob/master/src/share/classes/java/util/GregorianCalendar.java#L819), I don't think timezone would make a difference here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org