huaxingao commented on a change in pull request #28451: URL: https://github.com/apache/spark/pull/28451#discussion_r419770762
########## File path: docs/sql-ref-identifier.md ########## @@ -27,54 +27,47 @@ An identifier is a string used to identify a database object such as a table, vi #### Regular Identifier -{% highlight sql %} +```sql { letter | digit | '_' } [ , ... ] -{% endhighlight %} +``` Note: If `spark.sql.ansi.enabled` is set to true, ANSI SQL reserved keywords cannot be used as identifiers. For more details, please refer to [ANSI Compliance](sql-ref-ansi-compliance.html). #### Delimited Identifier -{% highlight sql %} +```sql `c [ ... ]` -{% endhighlight %} +``` ### Parameters -<dl> - <dt><code><em>letter</em></code></dt> - <dd> +* **letter** + Any letter from A-Z or a-z. - </dd> -</dl> -<dl> - <dt><code><em>digit</em></code></dt> - <dd> + +* **digit** + Any numeral from 0 to 9. - </dd> -</dl> -<dl> - <dt><code><em>c</em></code></dt> - <dd> + +* **c** + Any character from the character set. Use <code>`</code> to escape special characters (e.g., <code>`</code>). - </dd> -</dl> ### Examples -{% highlight sql %} +```sql -- This CREATE TABLE fails with ParseException because of the illegal identifier name a.b CREATE TABLE test (a.b int); -org.apache.spark.sql.catalyst.parser.ParseException: -no viable alternative at input 'CREATE TABLE test (a.'(line 1, pos 20) + org.apache.spark.sql.catalyst.parser.ParseException: Review comment: Since we indent 2 spaces for error messages in other place, I will do the same here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org