Github user harishreedharan commented on a diff in the pull request:
https://github.com/apache/spark/pull/5024#discussion_r26525484
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/Checkpoint.scala ---
@@ -43,10 +43,15 @@ class Checkpoint(@transient ssc: StreamingContext, val
checkpointTime: Time)
val delaySeconds = MetadataCleaner.getDelaySeconds(ssc.conf)
val sparkConfPairs = ssc.conf.getAll
- def sparkConf = {
- new SparkConf(false).setAll(sparkConfPairs)
+ def createSparkConf(): SparkConf = {
+ val newSparkConf = new SparkConf(loadDefaults =
false).setAll(sparkConfPairs)
.remove("spark.driver.host")
.remove("spark.driver.port")
+ val oldMaster = new SparkConf(loadDefaults =
true).getOption("spark.master")
--- End diff --
Why is this being called `oldMaster`? Isn't this an option wrapping the new
master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
