cloud-fan commented on a change in pull request #28477:
URL: https://github.com/apache/spark/pull/28477#discussion_r421984688
##########
File path:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedColumnReader.java
##########
@@ -102,14 +103,14 @@
// The timezone conversion to apply to int96 timestamps. Null if no
conversion.
private final ZoneId convertTz;
private static final ZoneId UTC = ZoneOffset.UTC;
- private final boolean rebaseDateTime;
+ private final String datetimeRebaseMode;
Review comment:
I don't think it affects perf, and the code will be less readable if we
see `mode == 0` instead of `"LEGACY".equals(mode)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
