igreenfield commented on a change in pull request #26624: URL: https://github.com/apache/spark/pull/26624#discussion_r422528642
########## File path: core/src/main/scala/org/apache/spark/util/ThreadUtils.scala ########## @@ -157,23 +259,23 @@ private[spark] object ThreadUtils { */ def newDaemonFixedThreadPool(nThreads: Int, prefix: String): ThreadPoolExecutor = { val threadFactory = namedThreadFactory(prefix) - Executors.newFixedThreadPool(nThreads, threadFactory).asInstanceOf[ThreadPoolExecutor] + MDCAwareThreadPoolExecutor.newFixedThreadPool(nThreads, threadFactory) Review comment: @cloud-fan I check and all uses of that function are from driver code. What do you think about reverting that one and create a new one called `newMDCAwareDaemonFixedThreadPool` so it can be used later? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org