MaxGekk commented on pull request #28548: URL: https://github.com/apache/spark/pull/28548#issuecomment-629692332
> We still have some tests that exercise other time zones right? @srowen Right, there is this method `DateTimeTestUtils.withDefaultTimeZone` which allows to set a time zone temporary: ``` $ find . -name "*Suite.scala" -print0|xargs -0 grep -l withDefaultTimeZone ./external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala ./sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ./sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala ./sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/RebaseDateTimeSuite.scala ./sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala ./sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala ./sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala ./sql/catalyst/src/test/scala/org/apache/spark/sql/util/TimestampFormatterSuite.scala ``` As far as I know there are no test suites that assume a default time zone that is different from `America/Los_Angeles`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
