Ngone51 commented on a change in pull request #28370:
URL: https://github.com/apache/spark/pull/28370#discussion_r426366660
##########
File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
##########
@@ -1829,7 +1901,58 @@ private[spark] class BlockManager(
data.dispose()
}
+ /**
+ * Class to handle block manager decommissioning retries
+ * It creates a Thread to retry offloading all RDD cache blocks
+ */
+ private class BlockManagerDecommissionManager(conf: SparkConf) {
+ @volatile private var stopped = false
+ private val sleepInterval = conf.get(
+ config.STORAGE_DECOMMISSION_REPLICATION_REATTEMPT_INTERVAL)
+
+ private val blockReplicationThread = new Thread {
+ override def run(): Unit = {
+ var failures = 0
+ while (blockManagerDecommissioning
+ && !stopped
+ && !Thread.interrupted()
Review comment:
> Unless the interrupt exception is caught inside of the block transfer
If there's an `InterruptedException` captured by block transfer, then
`Thread.interrupted()` inside `blockReplicationThread` would return false. And
what do you expect for this case?
If you want the decommission thread stop, then, `Thread.interrupted()` won't
work;
Or if you want the decommission to keep working, then,
`Thread.interrupted()` is useless because the status has already been
cleared(unless block transfer set it to interrupted again).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
