HyukjinKwon commented on a change in pull request #28534:
URL: https://github.com/apache/spark/pull/28534#discussion_r428433186
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -401,6 +401,81 @@ case class DayOfYear(child: Expression) extends
UnaryExpression with ImplicitCas
}
}
+abstract class NumberToTimestampBase extends UnaryExpression
+ with ImplicitCastInputTypes {
+
+ protected def upScaleFactor: Long
+
+ override def inputTypes: Seq[AbstractDataType] = Seq(LongType)
+
+ override def dataType: DataType = TimestampType
+
+ override def nullSafeEval(input: Any): Any = {
+ Math.multiplyExact(input.asInstanceOf[Long], upScaleFactor)
+ }
+
+ override protected def doGenCode(ctx: CodegenContext, ev: ExprCode):
ExprCode = {
+ if (upScaleFactor == 1) {
+ defineCodeGen(ctx, ev, c => c)
+ } else {
+ defineCodeGen(ctx, ev, c => s"java.lang.Math.multiplyExact($c,
$upScaleFactor)")
+ }
+ }
+}
+
+@ExpressionDescription(
+ usage = "_FUNC_(seconds) - Creates timestamp from the number of seconds
since UTC epoch.",
+ examples = """
+ Examples:
+ > SELECT _FUNC_(1230219000);
+ 2008-12-25 07:30:00
+ """,
+ group = "datetime_funcs",
+ since = "3.1.0")
+case class SecondsToTimestamp(child: Expression)
+ extends NumberToTimestampBase {
+
+ override def upScaleFactor: Long = MICROS_PER_SECOND
+
+ override def prettyName: String = "timestamp_seconds"
+}
+
+@ExpressionDescription(
+ usage = "_FUNC_(milliseconds) - " +
+ "Creates timestamp from the number of milliseconds since UTC epoch.",
Review comment:
nit: let's do either:
```
usage = """
_FUNC_(milliseconds) - Creates timestamp from the number of milliseconds
since UTC epoch.
...
"""
```
or
```
// scalastyle:off line.size.limit
@ExpressionDescription(
usage = "_FUNC_(milliseconds) - Creates timestamp from the number of
milliseconds since UTC epoch.",
...
// scalastyle:on line.size.limit
```
just for the sake of consistency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
