yaooqinn commented on a change in pull request #28592:
URL: https://github.com/apache/spark/pull/28592#discussion_r428604890
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateFormatter.scala
##########
@@ -77,14 +96,14 @@ trait LegacyDateFormatter extends DateFormatter {
class LegacyFastDateFormatter(pattern: String, locale: Locale) extends
LegacyDateFormatter {
@transient
- private lazy val fdf = FastDateFormat.getInstance(pattern, locale)
Review comment:
needed
https://github.com/apache/spark/pull/28592/files#diff-7f589e01d3e5e5ea284c1622527d4984R52
here, to fail if invaild
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
