Ngone51 commented on a change in pull request #28258:
URL: https://github.com/apache/spark/pull/28258#discussion_r428661567



##########
File path: core/src/main/scala/org/apache/spark/deploy/Client.scala
##########
@@ -176,6 +202,22 @@ private class ClientEndpoint(
       } else if (!Utils.responseFromBackup(message)) {
         System.exit(-1)
       }
+
+    case DriverStatusResponse(found, state, _, _, _) =>

Review comment:
       > If we removing polling from that, what logic should be handled there?
   
   we use this:
   
   ```
   forwardMessageThread.scheduleAtFixedRate(() => Utils.tryLogNonFatalError {
             MonitorDriverStatus()
           }, 0, REPORT_DRIVER_STATUS_INTERVAL, TimeUnit.MILLISECONDS)
   ```
   (but the initial delay need to change)
   
   in this way, submitting or killing drivers will still use it only for one 
time when `waitAppCompletion=false`. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to