cloud-fan commented on a change in pull request #28592:
URL: https://github.com/apache/spark/pull/28592#discussion_r428759386
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##########
@@ -86,6 +86,25 @@ trait DateTimeFormatterHelper {
throw e
}
}
+
+ // When the new DateTimeFormatter failed to initialize because of invalid
datetime pattern, it
+ // will throw IllegalArgumentException. If the pattern can be recognized by
the legacy formatter
+ // it will raise SparkUpgradeException to tell users to restore the previous
behavior via LEGACY
+ // policy or follow our guide to correct their pattern.
+ protected def checkLegacyFormatter[T1, T2](
Review comment:
what does the type parameter give us? The return type doesn't depend on
T1 or T2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
