cloud-fan commented on a change in pull request #28600:
URL: https://github.com/apache/spark/pull/28600#discussion_r429039911
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
##########
@@ -423,13 +434,21 @@ case class IntegralDivide(
private lazy val div: (Any, Any) => Any = {
val integral = left.dataType match {
+ // if it is of Integer type than cast it to Long
+ case _: IntegerType =>
Review comment:
We need to handle byte/short as well. I think it's easier to update the
type coercion rules to do the cast at the analysis time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
