cloud-fan commented on a change in pull request #28600: URL: https://github.com/apache/spark/pull/28600#discussion_r429082736
########## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ########## @@ -3495,6 +3495,13 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark assert(df4.schema.head.name === "randn(1)") checkIfSeedExistsInExplain(df2) } -} + test("SPARK-31761: test byte, short, integer overflow for (Divide) integral type ") { Review comment: For expression-level changes, I think it's better to add UT as well, to test both codegen and interpreted code path. Can you add a test in `ArithmeticExpressionSuite`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org