srowen commented on a change in pull request #28606:
URL: https://github.com/apache/spark/pull/28606#discussion_r429551102
##########
File path:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocatorBlacklistTracker.scala
##########
@@ -103,7 +103,16 @@ private[spark] class YarnAllocatorBlacklistTracker(
refreshBlacklistedNodes()
}
- def isAllNodeBlacklisted: Boolean = currentBlacklistedYarnNodes.size >=
numClusterNodes
+ def isAllNodeBlacklisted: Boolean = {
+ if (numClusterNodes <= 0) {
+ logWarn("There's no available nodes reported, please check Resource
Manager.")
+ false
+ } else if (currentBlacklistedYarnNodes.size >= numClusterNodes) {
+ true
Review comment:
if (x) true else false is redundant; just return the value of the
predicate as before.
##########
File path:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocatorBlacklistTracker.scala
##########
@@ -103,7 +103,16 @@ private[spark] class YarnAllocatorBlacklistTracker(
refreshBlacklistedNodes()
}
- def isAllNodeBlacklisted: Boolean = currentBlacklistedYarnNodes.size >=
numClusterNodes
+ def isAllNodeBlacklisted: Boolean = {
+ if (numClusterNodes <= 0) {
+ logWarn("There's no available nodes reported, please check Resource
Manager.")
Review comment:
"There are", or just drop the first word.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
