dongjoon-hyun commented on a change in pull request #28627:
URL: https://github.com/apache/spark/pull/28627#discussion_r429671303
##########
File path: project/SparkBuild.scala
##########
@@ -1001,9 +1004,9 @@ object TestSettings {
javaOptions += "-Xmx3g",
// Exclude tags defined in a system property
testOptions in Test += Tests.Argument(TestFrameworks.ScalaTest,
- sys.props.get("test.exclude.tags").map { tags =>
- tags.split(",").flatMap { tag => Seq("-l", tag) }.toSeq
- }.getOrElse(Nil): _*),
+ sys.props.get("test.exclude.tags").map(tag => tag.split(",").toSeq)
+ .getOrElse(defaultExcludedTagsForScalaTest).filter(!_.trim.isEmpty)
Review comment:
This looks not robust enough.
If a developer set an irrelevant tag (`ExtendedSQLTest` or
`ExtendedHiveTest`), `ChromeUITest` suddenly will cause a failure in the
irrelevant `Core` module.
##########
File path: project/SparkBuild.scala
##########
@@ -1001,9 +1004,9 @@ object TestSettings {
javaOptions += "-Xmx3g",
// Exclude tags defined in a system property
testOptions in Test += Tests.Argument(TestFrameworks.ScalaTest,
- sys.props.get("test.exclude.tags").map { tags =>
- tags.split(",").flatMap { tag => Seq("-l", tag) }.toSeq
- }.getOrElse(Nil): _*),
+ sys.props.get("test.exclude.tags").map(tag => tag.split(",").toSeq)
+ .getOrElse(defaultExcludedTagsForScalaTest).filter(!_.trim.isEmpty)
Review comment:
This looks not robust enough.
If a developer set an irrelevant tag (`ExtendedSQLTest` or
`ExtendedHiveTest`), `ChromeUITest` suddenly will cause a failure in the
irrelevant `Core` module. Did I understand correctly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
