rdblue commented on pull request #28523: URL: https://github.com/apache/spark/pull/28523#issuecomment-633641667
@cloud-fan, sorry for my confusion here. From the summary, I didn't realize that this actually added back the streaming modes using private interfaces and mistakenly thought you were trying to add back the public interfaces. That's what I intended to -1 and I didn't realize the mistake until you pointed out that the code hadn't changed, even now. I took the early lack of changes as simply a lack of progress, which led to my surprise when this was merged. Next time, let's try to communicate more clearly. Perhaps you didn't realize why I was confused, too, but it would have been helpful to point out that the solution we agreed on was what was already implemented. And it is still necessary to have a veto reversed; there is no timeout and inferring that a veto has been reversed is unreliable compared to asking for clarification. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
