Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/5079#issuecomment-82967018
Hm, the problem is that we should also add the source code of `hello.jar`
(probably after renaming it to `TestUdf.jar`). But I'm not quite sure where to
put it for now. That's why I said we can merge the fix first, and later add the
test in a proper way.
In Hive, there is separate Maven module [`itest/test-serde`] [1], which
results in a similar `TestSerDe.jar` solely for testing purposes. I wonder is
there a simpler way to handle this. Adding a module seems to be an overkill.
/cc @marmbrus @yhuai @pwendell
[1]: https://github.com/apache/hive/tree/release-0.13.1/itests/test-serde
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
