cloud-fan commented on a change in pull request #28650:
URL: https://github.com/apache/spark/pull/28650#discussion_r431699759
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -56,6 +56,28 @@ trait TimeZoneAwareExpression extends Expression {
@transient lazy val zoneId: ZoneId = DateTimeUtils.getZoneId(timeZoneId.get)
}
+trait TimestampFormatterHelper extends TimeZoneAwareExpression {
+
+ protected def formatString: Expression
+
+ protected def isParsing: Boolean
+
+ @transient final protected lazy val formatterOption:
Option[TimestampFormatter] =
+ if (formatString.foldable) {
+ Option(formatString.eval()).map(fmt => getFormatter(fmt.toString))
+ } else None
+
+ final protected def getFormatter(fmt: String): TimestampFormatter = {
+ val formatter = TimestampFormatter(
+ format = fmt,
+ zoneId = zoneId,
+ legacyFormat = SIMPLE_DATE_FORMAT,
+ needVarLengthSecondFraction = isParsing)
+ formatter.validatePatternString()
Review comment:
can we call `validatePatternString` in `TimestampFormatter.apply` for
legacy parser as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
