JkSelf commented on a change in pull request #28669:
URL: https://github.com/apache/spark/pull/28669#discussion_r432316209



##########
File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/OptimizeSkewedJoin.scala
##########
@@ -164,15 +164,15 @@ case class OptimizeSkewedJoin(conf: SQLConf) extends 
Rule[SparkPlan] {
       assert(left.partitionsWithSizes.length == 
right.partitionsWithSizes.length)
       val numPartitions = left.partitionsWithSizes.length
       // We use the median size of the original shuffle partitions to detect 
skewed partitions.

Review comment:
       We may also need to adjust the comment here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to