ulysses-you commented on a change in pull request #28647:
URL: https://github.com/apache/spark/pull/28647#discussion_r432539576
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
##########
@@ -1531,21 +1531,6 @@ class HiveDDLSuite
assert(targetTable.unsupportedFeatures.isEmpty,
"the unsupportedFeatures in the create table must be empty")
- val metastoreGeneratedProperties = Seq(
- "CreateTime",
- "transient_lastDdlTime",
- "grantTime",
- "lastUpdateTime",
- "last_modified_by",
- "last_modified_time",
- "Owner:",
- "totalNumberFiles",
- "maxFileSize",
- "minFileSize"
- )
-
assert(targetTable.properties.filterKeys(!metastoreGeneratedProperties.contains(_)).isEmpty,
Review comment:
We can't check all meta properties here. For example
`transient_lastDdlTime`, hive will add this properties when table created. So
the properties is always exists.
And add some meta properties test at new UT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
