cloud-fan commented on a change in pull request #28679: URL: https://github.com/apache/spark/pull/28679#discussion_r432907576
########## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala ########## @@ -639,11 +640,18 @@ class AdaptiveQueryExecSuite .range(0, 1000, 1, 10) .selectExpr("id % 1 as key2", "id as value2") .createOrReplaceTempView("skewData2") - val (_, innerAdaptivePlan) = runAdaptiveAndVerifyResult( - "SELECT key1 FROM skewData1 join skewData2 ON key1 = key2 group by key1") + + def checkSkewJoin(query: String, additionalShuffle: Boolean): Unit = { Review comment: nit: `optimizeSkewJoin: Boolean` to be more clear. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org