cloud-fan commented on a change in pull request #28592:
URL: https://github.com/apache/spark/pull/28592#discussion_r433122526
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/UnivocityParser.scala
##########
@@ -85,13 +85,13 @@ class UnivocityParser(
// We preallocate it avoid unnecessary allocations.
private val noRows = None
- private val timestampFormatter = TimestampFormatter(
+ private lazy val timestampFormatter = TimestampFormatter(
Review comment:
the formatter creation will validate the pattern string now, but
json/csv has a fallback and shouldn't fail because of invalid pattern string.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
