cloud-fan commented on a change in pull request #28807:
URL: https://github.com/apache/spark/pull/28807#discussion_r439902678
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/TableIdentifierParserSuite.scala
##########
@@ -388,12 +391,24 @@ class TableIdentifierParserSuite extends SparkFunSuite
with SQLHelper {
val reservedKeywordsInAnsiMode = allCandidateKeywords --
nonReservedKeywordsInAnsiMode
test("check # of reserved keywords") {
- val numReservedKeywords = 78
+ val numReservedKeywords = 75
assert(reservedKeywordsInAnsiMode.size == numReservedKeywords,
s"The expected number of reserved keywords is $numReservedKeywords, but
" +
s"${reservedKeywordsInAnsiMode.size} found.")
}
+ test("should follow reserved keywords in SQL:2016") {
Review comment:
can we make the test name clear? What we are testing is: `reserved
keywords in Spark are also reserved in SQL 2016`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
