cloud-fan commented on a change in pull request #28593:
URL: https://github.com/apache/spark/pull/28593#discussion_r439903944
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
##########
@@ -180,7 +180,8 @@ class HiveQuerySuite extends HiveComparisonTest with
SQLTestUtils with BeforeAnd
"SELECT CAST(CAST('NaN' AS DOUBLE) AS DECIMAL(1,1)) FROM src LIMIT 1")
createQueryTest("constant null testing",
- """SELECT
+ """set spark.sql.legacy.allowCastNumericToTimestamp=true;
Review comment:
We can update `CAST(1 AS TIMESTAMP)` to `CAST('1970-01-01 10:10:10' AS
TIMESTAMP)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
