ulysses-you commented on a change in pull request #28840:
URL: https://github.com/apache/spark/pull/28840#discussion_r441580909
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##########
@@ -606,38 +601,16 @@ class ResolveSessionCatalog(
ignoreIfExists,
replace)
} else {
- val FunctionIdentifier(function, database) =
- parseSessionCatalogFunctionIdentifier(nameParts, "CREATE FUNCTION")
- CreateFunctionCommand(database, function, className, resources,
isTemp, ignoreIfExists,
- replace)
- }
- }
-
- // TODO: move function related v2 statements to the new framework.
- private def parseSessionCatalogFunctionIdentifier(
Review comment:
Move this method to `LookupCatalog.CatalogAndFunctionIdentifier` and
drop the sql param.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
