maropu commented on a change in pull request #28852: URL: https://github.com/apache/spark/pull/28852#discussion_r441914498
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ########## @@ -835,6 +835,15 @@ object SQLConf { .longConf .createWithDefault(250 * 1024 * 1024) + val HIVE_FILESOURCE_PARTITION_FILE_CACHE_TTL = + buildConf("spark.sql.hive.filesourcePartitionFileCacheTTL") + .doc("When positive, it's used as a TTL (time-to-live) value for the partition file " + + "metadata cache. This conf only has an effect when hive filesource partition management " + + "is enabled.") Review comment: How about rephrasing it like this? ``` .doc("Time-to-live (TTL) value for the partition file metadata cache. This configuration " + "only has an effect when this value having a positive value and setting `hive` to " + s"${StaticSQLConf.CATALOG_IMPLEMENTATION}.") ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org