TJX2014 commented on a change in pull request #28856: URL: https://github.com/apache/spark/pull/28856#discussion_r442613764
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala ########## @@ -2635,7 +2643,11 @@ object Sequence { var i = 0 while (t < exclusiveItem ^ stepSign < 0) { - arr(i) = fromLong(t / scale) + arr(i) = if (scale == 1) { + fromLong(t / scale) + } else { + fromLong(Math.round(t / scale.toFloat)) Review comment: We could get date from `Math.round(t / scale.toFloat)`, if the target is timestamp, the former ` fromLong(t / scale)` could be used. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org