cloud-fan commented on a change in pull request #28853:
URL: https://github.com/apache/spark/pull/28853#discussion_r442717100
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategySuite.scala
##########
@@ -528,6 +528,28 @@ class FileSourceStrategySuite extends QueryTest with
SharedSparkSession with Pre
}
}
+ test("Add spark.sql.files.minPartitionNum config") {
+ withSQLConf(SQLConf.FILES_MIN_PARTITION_NUM.key -> "1") {
+ val table =
+ createTable(files = Seq(
+ "file1" -> 1,
+ "file2" -> 1,
+ "file3" -> 1
+ ))
+ assert(table.rdd.partitions.length == 1)
+ }
+
+ withSQLConf(SQLConf.FILES_MIN_PARTITION_NUM.key -> "10") {
+ val table =
+ createTable(files = Seq(
+ "file1" -> 1,
+ "file2" -> 1,
+ "file3" -> 1
+ ))
+ assert(table.rdd.partitions.length == 3)
+ }
Review comment:
can we add more tests to make sure that this is really for min partition
number?
e.g. we can create more partitions than the min number, as we make each
partition 64mb.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
