dongjoon-hyun commented on a change in pull request #28863:
URL: https://github.com/apache/spark/pull/28863#discussion_r443075731
##########
File path: external/docker-integration-tests/pom.xml
##########
@@ -130,15 +130,9 @@
<artifactId>postgresql</artifactId>
<scope>test</scope>
</dependency>
- <!-- Oracle ojdbc jar, used for oracle integration suite for docker
testing.
- See https://github.com/apache/spark/pull/11306 for background on why we
need
- to use a an ojdbc jar for the testcase. The maven dependency here is
commented
- because currently the maven repository does not contain the ojdbc jar
mentioned.
- Once the jar is available in maven, this could be uncommented. -->
- <dependency>
- <groupId>com.oracle</groupId>
- <artifactId>ojdbc6</artifactId>
- <version>11.2.0.1.0</version>
+ <dependency>
+ <groupId>com.oracle.database.jdbc</groupId>
+ <artifactId>ojdbc8</artifactId>
Review comment:
Hi, @gaborgsomogyi .
`Support Oracle Kerberos login in JDBC connector` is a good contribution,
but upgrading the existing `OracleIntegrationSuite` is also another independent
good contribution.
Could you proceed upgrading `OracleIntegrationSuite` first as a separate
JIRA?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
