viirya commented on a change in pull request #28876:
URL: https://github.com/apache/spark/pull/28876#discussion_r443165193
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggUtils.scala
##########
@@ -148,7 +149,15 @@ object AggUtils {
case ne: NamedExpression => ne
case other => Alias(other, other.toString)()
}
- val distinctAttributes = namedDistinctExpressions.map(_.toAttribute)
+ // Ideally this should be done in `NormalizeFloatingNumbers`, but we do it
here because
Review comment:
Looks okay to combine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
