Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/5130#issuecomment-84835800
As @zsxwing says, it appears that the code is already trying to handle this
case. Do `InvocationTargetExceptions` only wrap `Exception`s and not all
`Throwable`s? If that's the case, then the patch's approach seems to make
sense. If they wrap `Error`s as well, then the fix would be to replace
`Exception` with `Throwable` in the match block of the
`InvocationTargetException` cause.
Also, how were we ending up with a success before? If anything forced us
to break out of that try block, it seems like we wouldn't call `finish` with
SUCCESS . Or does YARN just assume success in the case where we shut down
without a report? (I can look this up if you don't know).
Last, what if we run into an `OutOfMemoryError` on a separate thread?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
