cloud-fan commented on a change in pull request #28875: URL: https://github.com/apache/spark/pull/28875#discussion_r443437559
########## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ########## @@ -437,8 +437,7 @@ dmlStatementNoWith USING (source=multipartIdentifier | '(' sourceQuery=query')') sourceAlias=tableAlias ON mergeCondition=booleanExpression - matchedClause* - notMatchedClause* #mergeIntoTable + matchedOrNotMatchedClause* #mergeIntoTable Review comment: yea I think so. Seems we can keep this parser rule unchanged. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org