Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/5119#discussion_r26925330 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/QueryTest.scala --- @@ -1,140 +0,0 @@ -/* --- End diff -- yes. These are the two files which were copied over, then allowed to age while the originals were maintained. 1. cut these files and things don't build any more 1. add the mvn changes and they do compile, except where `CachedTableSuite` had another method from the original tests pasted in. 1. remove that method, the updated parent class exports the method, and all is well.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org