sap1ens commented on a change in pull request #28852:
URL: https://github.com/apache/spark/pull/28852#discussion_r445226247



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -835,6 +835,15 @@ object SQLConf {
       .longConf
       .createWithDefault(250 * 1024 * 1024)
 
+  val HIVE_FILESOURCE_PARTITION_FILE_CACHE_TTL =
+    buildConf("spark.sql.hive.filesourcePartitionFileCacheTTL")

Review comment:
       @maropu @gatorsmile I've changed the config option to 
`spark.sql.metadataCacheTTL` and applied it to `FileStatusCache` as well as 
`SessionCatalog` in 
https://github.com/apache/spark/pull/28852/commits/28da5cfd39dba6a8319dd1cdfe39e51ed5cbdea5.
 What do you think? 
   
   I'm happy to update `spark.sql.hive.filesourcePartitionFileCacheSize` (drop 
`hive` prefix), but it's clearly out of scope here, I could follow-up with 
another PR after this one is resolved.
   
   Thanks again.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to