HyukjinKwon commented on a change in pull request #28919:
URL: https://github.com/apache/spark/pull/28919#discussion_r445274348



##########
File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala
##########
@@ -460,7 +460,12 @@ abstract class SparkStrategies extends 
QueryPlanner[SparkPlan] {
               // because `distinctExpressions` is not extracted during logical 
phase.
               NormalizeFloatingNumbers.normalize(e) match {
                 case ne: NamedExpression => ne
-                case other => Alias(other, other.toString)()

Review comment:
       I see, thanks. Can we at least leave a short comment why we're doing it 
here alone?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to