Ngone51 commented on a change in pull request #28924:
URL: https://github.com/apache/spark/pull/28924#discussion_r447580528
##########
File path: core/src/main/scala/org/apache/spark/util/RpcUtils.scala
##########
@@ -54,6 +56,12 @@ private[spark] object RpcUtils {
RpcTimeout(conf, Seq(RPC_LOOKUP_TIMEOUT.key, NETWORK_TIMEOUT.key), "120s")
}
+ /**
+ * Infinite timeout is used internally, so there's no actual timeout
property controls it.
+ * And timeout property should never be accessed since infinite means we
never timeout.
Review comment:
Updated.
`timeout property` actually is the third field of `RpcTimeout`. You could
check its usage inside `RpcTimeout`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
