moomindani commented on a change in pull request #28953:
URL: https://github.com/apache/spark/pull/28953#discussion_r448072931
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
##########
@@ -156,9 +157,16 @@ object JDBCRDD extends Logging {
val url = options.url
val dialect = JdbcDialects.get(url)
val quotedColumns = requiredColumns.map(colName =>
dialect.quoteIdentifier(colName))
+
+ val conn = JdbcUtils.createConnectionFactory(options)
+ options.preActions match {
+ case Some(i) =>
+ runQuery(conn(), i, options)
Review comment:
Thanks for pointing the reference. It makes sense.
BTW, in the current diff, all the `runQuery` calls have `conn` instead of
`conn()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
