ulysses-you commented on a change in pull request #28647:
URL: https://github.com/apache/spark/pull/28647#discussion_r448102285
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
##########
@@ -1066,7 +1066,10 @@ private[hive] object HiveClientImpl extends Logging {
hiveTable.setSerializationLib(
table.storage.serde.getOrElse("org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe"))
table.storage.properties.foreach { case (k, v) =>
hiveTable.setSerdeParam(k, v) }
- table.properties.foreach { case (k, v) => hiveTable.setProperty(k, v) }
+ // Hive only retain the useful properties through serde class annotation.
+ // For better compatible with Hive, we remove the metastore properties.
+ val hiveProperties = table.properties --
HIVE_METASTORE_GENERATED_PROPERTIES
Review comment:
It also affect `createTable`, but seems fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
