cloud-fan commented on a change in pull request #28833:
URL: https://github.com/apache/spark/pull/28833#discussion_r448111176
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala
##########
@@ -292,6 +293,8 @@ case class PreprocessTableCreation(sparkSession:
SparkSession) extends Rule[Logi
"in the table definition of " + table.identifier,
sparkSession.sessionState.conf.caseSensitiveAnalysis)
+ assertNoNullTypeInSchema(schema)
Review comment:
Is this needed? I think the changes in `ResolveCatalogs` and
`ResolveSessionCatalog` should cover all the commands.
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala
##########
@@ -106,7 +107,7 @@ class ResolveHiveSerdeTable(session: SparkSession) extends
Rule[LogicalPlan] {
} else {
withStorage
}
-
+ assertNoNullTypeInSchema(withSchema.schema)
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
