LantaoJin commented on a change in pull request #28833:
URL: https://github.com/apache/spark/pull/28833#discussion_r448159476
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
##########
@@ -2309,6 +2309,108 @@ class HiveDDLSuite
}
}
+ test("SPARK-20680: Spark-sql do not support for void column datatype") {
+ withTable("t") {
+ withView("tabVoidType") {
+ val client =
+
spark.sharedState.externalCatalog.unwrapped.asInstanceOf[HiveExternalCatalog].client
+ client.runSqlHive("CREATE TABLE t (t1 int)")
+ client.runSqlHive("INSERT INTO t VALUES (3)")
+ client.runSqlHive("CREATE VIEW tabVoidType AS SELECT NULL AS col FROM
t")
+ checkAnswer(spark.table("tabVoidType"), Row(null))
+ // No exception shows
+ val desc = spark.sql("DESC tabVoidType").collect().toSeq
+ assert(desc.contains(Row("col", "null", null)))
Review comment:
Add `def simpleString = "void"` in NullType will change many codes
includes python. I revert this in commits/5aa4c1a. Now I think it is necessary.
We should declare "null" is just a literal not a data type in Spark.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
