TJX2014 commented on a change in pull request #28882:
URL: https://github.com/apache/spark/pull/28882#discussion_r448168566
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogSuite.scala
##########
@@ -181,41 +182,47 @@ class HiveExternalCatalogSuite extends
ExternalCatalogSuite {
"INSERT overwrite directory \"fs://localhost/tmp\" select 1 as a"))
}
- test("SPARK-31061: alterTable should be able to change table provider") {
+ test("SPARK-31061: alterTable should be able to change table provider/hive")
{
val catalog = newBasicCatalog()
- val parquetTable = CatalogTable(
- identifier = TableIdentifier("parq_tbl", Some("db1")),
- tableType = CatalogTableType.MANAGED,
- storage = storageFormat.copy(locationUri = Some(new
URI("file:/some/path"))),
- schema = new StructType().add("col1", "int").add("col2", "string"),
- provider = Some("parquet"))
- catalog.createTable(parquetTable, ignoreIfExists = false)
Review comment:
@brkyvz @cloud-fan
[https://github.com/apache/spark/pull/27822](https://github.com/apache/spark/pull/27822)
I find `storage = storageFormat.copy(locationUri = Some(new
URI("file:/some/path"))),` maybe useless, and will cause the path incompatible
with path property. So shall we remove it and merge the two test cases to one ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
