dongjoon-hyun commented on a change in pull request #28833:
URL: https://github.com/apache/spark/pull/28833#discussion_r448175519
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Util.scala
##########
@@ -346,4 +346,23 @@ private[sql] object CatalogV2Util {
}
}
}
+
+ def failNullType(dt: DataType): Unit = {
+ def containsNullType(dt: DataType): Boolean = dt match {
+ case ArrayType(et, _) => containsNullType(et)
+ case MapType(kt, vt, _) => containsNullType(kt) || containsNullType(vt)
+ case StructType(fields) => fields.exists(f =>
containsNullType(f.dataType))
+ case _ => dt.isInstanceOf[NullType]
+ }
+ if (containsNullType(dt)) {
+ throw new AnalysisException(
+ "Cannot create tables with VOID type.")
Review comment:
Thank you for checking, @LantaoJin . This is also confusing to me. From
Hive side, `VOID` is a type name. But, Apache Spark side,
- We have `null` literal:
https://spark.apache.org/docs/latest/sql-ref-literals.html#null-literal
- We have only `nullable` types:
https://spark.apache.org/docs/latest/sql-ref-datatypes.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
