srowen opened a new pull request #28971:
URL: https://github.com/apache/spark/pull/28971


   ### What changes were proposed in this pull request?
   
   The purpose of this PR is to partly resolve SPARK-29292, and fully resolve 
SPARK-30010, which should allow Spark to compile vs Scala 2.13 in Spark Core 
and up through GraphX (not SQL, Streaming, etc).
   
   Note that we are not trying to determine here whether this makes Spark work 
on 2.13 yet, just compile, as a prerequisite for assessing test outcomes. 
However, of course, we need to ensure that the change does not break 2.12.
   
   The changes are, in the main, adding .toSeq and .toMap calls where mutable 
collections / maps are returned as Seq / Map, which are immutable by default in 
Scala 2.13. The theory is that it should be a no-op for Scala 2.12 (these 
return themselves), and required for 2.13.
   
   There are a few non-trivial changes highlighted below.
   In particular, to get Core to compile, we need to resolve SPARK-30010 which 
removes a deprecated SparkConf method
   
   ### Why are the changes needed?
   
   Eventually, we need to support a Scala 2.13 build, perhaps in Spark 3.1. 
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes, removal of the deprecated SparkConf.setAll overload, which isn't legal 
in Scala 2.13 anymore.
   
   
   ### How was this patch tested?
   
   Existing tests. (2.13 was not _tested_; this is about getting it to compile 
without breaking 2.12)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to