cloud-fan commented on a change in pull request #28926:
URL: https://github.com/apache/spark/pull/28926#discussion_r450009801
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -2612,6 +2612,11 @@ object Sequence {
val stepDays = step.days
val stepMicros = step.microseconds
+ if (scale == MICROS_PER_DAY && stepMonths == 0 && stepDays == 0) {
+ throw new IllegalArgumentException(
+ "sequence step must be a day interval if start and end values are
dates")
+ }
+
if (stepMonths == 0 && stepMicros == 0 && scale == MICROS_PER_DAY) {
Review comment:
We can probably add comments for each branch. For example, this branch
is for adding days to date start/end.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
