Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4823#discussion_r27059177
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -42,6 +42,18 @@ private[ui] class AllJobsPage(parent: JobsTab) extends
WebUIPage("") {
}
def makeRow(job: JobUIData): Seq[Node] = {
+ // scalastyle:off
+ val killLink = if (killEnabled) {
+ val killLinkUri =
s"${UIUtils.prependBaseUri(parent.basePath)}/jobs/job/kill?" +
+ s"id=${job.jobId}&terminate=true"
+ val confirm = "return window.confirm(" +
+ s"'Are you sure you want to kill job ${job.jobId} ?');"
+ <span class="kill-link">
+ (<a href={killLinkUri} onclick={confirm}>kill</a>)
+ </span>
+ }
+ // scalastyle:on
--- End diff --
also, I'm not sure what the type of `killLink` is. It seems to me to be
`Any` because there's no else case. Can you make it explicit by adding an else
case that returns `Seq.empty`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
