TJX2014 commented on a change in pull request #28926:
URL: https://github.com/apache/spark/pull/28926#discussion_r450118579
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -2618,9 +2618,11 @@ object Sequence {
}
if (stepMonths == 0 && stepMicros == 0 && scale == MICROS_PER_DAY) {
+ // Adding pure days to date start/end
backedSequenceImpl.eval(start, stop, fromLong(stepDays))
} else if (stepMonths == 0 && stepDays == 0 && scale == 1) {
+ // Adding pure microseconds to timestamp start/end
Review comment:
@cloud-fan Thanks, I add more comments for pure days and months branch,
the former exception check seems the exception content has enough informs, and
the last branch seems have detail content.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
