wangyum commented on a change in pull request #28991:
URL: https://github.com/apache/spark/pull/28991#discussion_r450121442
##########
File path:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
##########
@@ -874,6 +874,22 @@ class HiveThriftBinaryServerSuite extends
HiveThriftJdbcTest {
assert(rs.getString(1) === expected.toString)
}
}
+
+ test("SPARK-26533: Support query auto timeout cancel on thriftserver") {
+ withJdbcStatement() { statement =>
+ statement.setQueryTimeout(1)
+ val e = intercept[SQLException] {
+ statement.execute("select java_method('java.lang.Thread', 'sleep',
3000L)")
+ }.getMessage
+ assert(e.contains("Query timed out after"))
+
+ statement.setQueryTimeout(0)
+ statement.execute("select java_method('java.lang.Thread', 'sleep',
3000L)")
Review comment:
Could you change query to: `SELECT 'test1',
java_method('java.lang.Thread', 'sleep', 3000L);` and assert the result to make
the test more robust.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
