StefanXiepj opened a new pull request #29010: URL: https://github.com/apache/spark/pull/29010
<!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html 2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'. 4. Be sure to keep the PR description updated to reflect all changes. 5. Please write your PR title to summarize what this PR proposes. 6. If possible, provide a concise example to reproduce the issue for a faster review. 7. If you want to add a new configuration, please read the guideline first for naming configurations in 'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'. --> ### What changes were proposed in this pull request? <!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below. 1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers. 2. If you fix some SQL features, you can provide some references of other DBMSes. 3. If there is design documentation, please add the link. 4. If there is a discussion in the mailing list, please add the link. --> When somebody changed the type of partition's field, spark will throw ClassCastException. For example, we have a table like this: ``` drop table if exists cast_exception_test; create table cast_exception_test(c1 int, c2 string) partitioned by (dt string) stored as orc; insert into table cast_exception_test partition(dt='2020-04-08') values('1', 'jeff_1'); ``` If you change the field's type, spark will throw ClassCastException, but hive will not: ``` -- change the field's type alter table cast_exception_test change column c1 c1 string; -- hive correct, but spark throws ClassCastException select * from cast_exception_test where dt='2020-04-08'; ``` ### Why are the changes needed? <!-- Please clarify why the changes are needed. For instance, 1. If you propose a new API, clarify the use case for a new API. 2. If you fix a bug, you can clarify why it is a bug. --> When the table has many fields, we don's known which field has been changed. If we print out log about this exception, it will very helpful for us to troubleshoot. ### Does this PR introduce _any_ user-facing change? <!-- Note that it means *any* user-facing change including all aspects such as the documentation fix. If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible. If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master. If no, write 'No'. --> When the ClassCastException is caused by changed field's type, you can search which field has problem in exexutor logs: ``` 20/04/09 17:22:05 ERROR hive.HadoopTableReader: Exception thrown in field <c1> ``` ### How was this patch tested? <!-- If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible. If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. If tests were not added, please describe why they were not added and/or why it was difficult to add. --> ``` drop table if exists cast_exception_test; create table cast_exception_test(c1 int, c2 string) partitioned by (dt string) stored as orc; insert into table cast_exception_test partition(dt='2020-04-08') values('1', 'jeff_1'); alter table cast_exception_test change column c1 c1 string; select * from cast_exception_test where dt='2020-04-08'; ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org