xuanyuanking commented on a change in pull request #28975:
URL: https://github.com/apache/spark/pull/28975#discussion_r450162731
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
##########
@@ -259,6 +269,9 @@ class SymmetricHashJoinStateManager(
return null
}
+ // Make a copy on value row, as below cleanup logic may update the
value row silently.
+ currentValue = currentValue.copy(value = currentValue.value.copy())
Review comment:
Yep, also prefer the first approach personally. As the issue was in v2
format, the first version is a straightforward way.
@cloud-fan typo? `... unnecessary copies for v1 format`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
